tcp: Make firmware strings (in packet suffix) optional #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple of the following reports are going around:
Buffer size too small (85 instead of at least 125 bytes)
As it turns out these last 40 bytes contain exactly the `firmware` and
`firmware_slave` strings, which are not sent by certain 3000TL
inverters. Move the fields to a secondary, optional `Structure` to
allow these devices to be read out over TCP, and warn when the length
of a reply isn't matching one of the known message sizes so that we can
potentially discover more different layouts.
Makes `_parse_information_reply()` quite a bit slimmer
MarijnS95
commented
Apr 13, 2023
MarijnS95
commented
Apr 13, 2023
MarijnS95
force-pushed
the
tcp-firmware-strings-optional
branch
from
4637629 to
7a6168c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 341 357 +16
Branches 55 57 +2
=========================================
+ Hits 341 357 +16
☔ View full report in Codecov by Sentry. |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
robbinjanssen
added
no-stale
klaasnicolaas
added
the
refactor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes robbinjanssen/home-assistant-omnik-inverter#142, robbinjanssen/home-assistant-omnik-inverter#134 (comment)
Multiple of the following reports are going around:
As it turns out these last 40 bytes contain exactly the
firmwareandfirmware_slavestrings, which are not sent by certain 3000TL inverters. Move the fields to a secondary, optionalStructureto allow these devices to be read out over TCP, and warn when the length of a reply isn't matching one of the known message sizes so that we can potentially discover more different layouts.