Catch invalid temperature for offline inverters using TCP #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbinjanssen
added
the
enhancement
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 325 327 +2
Branches 55 55
=========================================
+ Hits 325 327 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MarijnS95
reviewed
Feb 7, 2023
MarijnS95
reviewed
Feb 8, 2023
omnikinverter/tcp.py
Outdated
| @@ -255,10 +255,15 @@ def int_to_bool(num: int) -> bool: | |||
| 1: True, | |||
| }[num] | |||
|
|
|||
| # Set temperature to None if it matches 65326, this is returned | |||
| # when the inverter is "offline". | |||
| def temperature_to_int(temp: int) -> Optional[float]: | |||
MarijnS95
approved these changes
Feb 8, 2023
klaasnicolaas
approved these changes
Feb 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
For some reason an inverter that is offline returns "65326" as a temperature. This PR makes sure that value is checked and
Noneis returned instead of 6532.6 degrees 🔥Potentially breaking because
Noneis returned instead of a float. Please decide @klaasnicolaas.