Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alarm_code value #247

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Add alarm_code value #247

merged 1 commit into from
Feb 3, 2023

Conversation

klaasnicolaas
Copy link
Owner

Add a new value for the source_type: Javascript, JSON and HTML

@klaasnicolaas klaasnicolaas added the new-feature New features or request. label Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (8d8f245) compared to base (8a0edb1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #247   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          320       321    +1     
  Branches        55        55           
=========================================
+ Hits           320       321    +1     
Impacted Files Coverage Δ
omnikinverter/models.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@robbinjanssen robbinjanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Oct 7, 2022
@klaasnicolaas klaasnicolaas added hacktoberfest-accepted Issues/PRs are participating in the Hacktoberfest. no-stale This issue or PR is exempted from the stable bot. and removed stale There has not been activity on this issue or PR for quite some time. labels Oct 8, 2022
@klaasnicolaas klaasnicolaas removed the hacktoberfest-accepted Issues/PRs are participating in the Hacktoberfest. label Oct 8, 2022
@robbinjanssen robbinjanssen merged commit 02e091d into main Feb 3, 2023
@robbinjanssen robbinjanssen deleted the add/alarm_code branch February 3, 2023 13:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or request. no-stale This issue or PR is exempted from the stable bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants