tcp: Allow unknown0 to be 0 in addition to UINT16_MAX
#198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it turns out this field has a different value on a 4000TL(2?): while it doesn't bring us any closer to the meaning of this field, allow it to not spam the logs full with it.
Codecov Report
@@ Coverage Diff @@
## main #198 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 325 325
Branches 65 65
=========================================
Hits 325 325
Continue to review full report at Codecov.
|
klaasnicolaas
approved these changes
May 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out this field has a different value on a 4000TL(2?): while it doesn't bring us any closer to the meaning of this field, allow it to not spam the logs full with it.