tcp: Allow serial number to mismatch in reply #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it turns out the serial number _does not seem_ to be required in the request packet, in order to extract data from the inverter. This field is present in the "header" around the TCP packet, most likely to keep the format the same between requests and replies but is not actually checked by the inverter before it sends back a valid reply. By being more lenient here we can recommend - or at least request - the community to test with a nonmatching (e.g. `0`) serial number, instead of having to look it up on the screen or through the `javascript` backend.
Codecov Report
@@ Coverage Diff @@
## main #197 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 325 323 -2
Branches 65 63 -2
=========================================
- Hits 325 323 -2
Continue to review full report at Codecov.
|
klaasnicolaas
approved these changes
May 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out the serial number does not seem to be required in the request packet, in order to extract data from the inverter. This field is present in the "header" around the TCP packet, most likely to keep the format the same between requests and replies but is not actually checked by the inverter before it sends back a valid reply.
By being more lenient here we can recommend - or at least request - the community to test with a nonmatching (e.g.
0) serial number, instead of having to look it up on the screen or through thejavascriptbackend.