Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_output: source_type is "javascript", not "js" #159

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

MarijnS95
Copy link
Contributor

None of the code mentions the string "js", only written-out "javascript" is used for this source_type.

None of the code mentions the string `"js"`, only written-out
`"javascript"` is used for this `source_type`.
@klaasnicolaas klaasnicolaas added the enhancement Enhancement of the code, not introducing new features. label Mar 26, 2022
@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #159 (4d3bc26) into main (8857fff) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #159   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          182       182           
  Branches        38        38           
=========================================
  Hits           182       182           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8857fff...4d3bc26. Read the comment docs.

Copy link
Owner

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end it doesn't matter much because javascript is always the fallback option.

@klaasnicolaas klaasnicolaas merged commit cdd2a94 into klaasnicolaas:main Mar 26, 2022
@MarijnS95 MarijnS95 deleted the test-fix-source-type branch March 26, 2022 21:32
@MarijnS95
Copy link
Contributor Author

In the end it doesn't matter much because javascript is always the fallback option.

I've changed this in #134 to still rely on the @dataclass default but to not correct for potential typos in this field - in that case these functions should really just fail with "I have no idea what source you want".

@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants