Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KGA-49]: fix OOB read in parse_storage_keys on malformed inputs #1627

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Nov 20, 2024

Fixes an issue where parsing malformed access lists could have undefined behavior due to OOB reads. This had no impact on the protocol whatsoever and could only discard the benefits from eip2930

Copy link

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.7%. Comparing base (4a63a66) to head (2eb8cef).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1627     +/-   ##
=======================================
- Coverage   63.9%   63.7%   -0.2%     
=======================================
  Files         44      44             
  Lines       8363    8367      +4     
=======================================
- Hits        5349    5337     -12     
- Misses      3014    3030     +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ClementWalter ClementWalter merged commit df0f345 into main Nov 20, 2024
16 checks passed
@ClementWalter ClementWalter deleted the fix/oob-read-parse-storage-keys branch November 20, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants