Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KGA-2] [KGA-51] fix: underconstrained hint in initialize_jumpdests #1626

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Nov 20, 2024

Fixes an underconstrained hint in initialize_jumpdests. Avoids a malicious prover to continue iterating over the bytecode limit and consuming extra resources, but has no impact over code execution

https://github.com/code-423n4/2024-09-kakarot-findings/issues/26
https://github.com/code-423n4/2024-09-kakarot-findings/issues/67

Copy link

ClementWalter
ClementWalter previously approved these changes Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.7%. Comparing base (4a63a66) to head (491d3d5).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1626     +/-   ##
=======================================
- Coverage   63.9%   63.7%   -0.2%     
=======================================
  Files         44      44             
  Lines       8363    8331     -32     
=======================================
- Hits        5349    5315     -34     
- Misses      3014    3016      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ClementWalter ClementWalter merged commit 204b3d7 into main Nov 20, 2024
16 checks passed
@ClementWalter ClementWalter deleted the fix/underconstrained-hint branch November 20, 2024 09:45
@enitrat enitrat changed the title [KGA-51] fix: underconstrained hint in initialize_jumpdests [KGA-2] [KGA-51] fix: underconstrained hint in initialize_jumpdests Nov 20, 2024
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants