Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KGA-100] [KGA-56] fix: memory expansion early return condition #1619

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Nov 19, 2024

Fixes the early return condition in calculate_gas_extend_memory that was off-by-one.
This had no impact on the code, as the correct memory was computed after. This just did not early returned in all cases.

https://github.com/code-423n4/2024-09-kakarot-findings/issues/101
https://github.com/code-423n4/2024-09-kakarot-findings/issues/78

Copy link

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.7%. Comparing base (5cdbb52) to head (81b2f3f).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1619     +/-   ##
=======================================
- Coverage   64.0%   63.7%   -0.3%     
=======================================
  Files         44      44             
  Lines       8363    8363             
=======================================
- Hits        5354    5331     -23     
- Misses      3009    3032     +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ClementWalter ClementWalter merged commit 63f6320 into main Nov 20, 2024
16 checks passed
@ClementWalter ClementWalter deleted the fix/memory-expansion-early-return branch November 20, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants