-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KGA-87] fix: high offset memory expansion computations #1604
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
=======================================
- Coverage 63.6% 63.6% -0.1%
=======================================
Files 44 44
Lines 8332 8343 +11
=======================================
+ Hits 5301 5307 +6
- Misses 3031 3036 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use from starkware.cairo.lang.cairo_constants import DEFAULT_PRIME
Fixes computation on high memory offsets.
The remediation proposed by the audit finding was not sufficient enough. This one looks fine, although a bit more costly (even though uint256_add is not that computationally intensive)
https://github.com/code-423n4/2024-09-kakarot-findings/issues/4
This change is