[KGA-4] [KGA-118] [KGA-119] [KGA-127] [KGA-133] fix: reentrancy check in eth_call #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obatirou
commented
Nov 6, 2024
obatirou
force-pushed
the
reentrancy-check-kakarot-level
branch
from
ac5e690
to
5eed36d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1582 +/- ##
=======================================
+ Coverage 63.5% 63.6% +0.1%
=======================================
Files 44 44
Lines 8366 8338 -28
=======================================
- Hits 5314 5309 -5
+ Misses 3052 3029 -23 ☔ View full report in Codecov by Sentry. |
tests/end_to_end/CairoPrecompiles/test_call_cairo_precompile.py
Outdated
Show resolved
Hide resolved
ClementWalter
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/code-423n4/2024-09-kakarot-findings/issues/64
What is the new behavior?
Reentrancy check is moved at Kakarot level in eth_call
This change is