Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: CairoLib #1510

Merged
merged 3 commits into from
Oct 17, 2024
Merged

refactor: CairoLib #1510

merged 3 commits into from
Oct 17, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Oct 16, 2024

Refactors the CairoLib and its usage.
The CairoLib from kakarot-lib now only exposes public, non-whitelisted entrypoints (including multicall).

As such, the DualVmToken and other contracts relying on the whitelisted delegatecall feature are using an internal WhitelistedCallCairoLib library.


This change is Reviewable

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.9%. Comparing base (2b8ec8c) to head (425e08b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1510   +/-   ##
=====================================
  Coverage   61.8%   61.9%           
=====================================
  Files         44      44           
  Lines       8335    8335           
=====================================
+ Hits        5156    5160    +4     
+ Misses      3179    3175    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ClementWalter
ClementWalter previously approved these changes Oct 16, 2024
obatirou
obatirou previously approved these changes Oct 16, 2024
@enitrat enitrat dismissed stale reviews from obatirou and ClementWalter via 2f09a18 October 16, 2024 16:31
@enitrat enitrat merged commit 0ce3b5f into main Oct 17, 2024
16 checks passed
@enitrat enitrat deleted the refactor/cairo-lib branch October 17, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants