test: get_starknet_address #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
reviewed
Oct 2, 2024
|
@enitrat Thank you for your review and thorough explanation on what was problematic with my test. I've made the requested changes please tell me if that's OK now. |
enitrat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Unit test of the KakarotCore::get_starknet_address function
Please check the type of change your PR introduces:
What is the current behavior?
Function not tested.
Resolves: #991
What is the new behavior?
Function tested with full coverage of the 2 possible outcomes.
Does this introduce a breaking change?
This change is