Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos #1000

Merged
merged 5 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/contracts/src/cairo1_helpers.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ pub trait IHelpers<T> {
/// * The recovered Ethereum address.
fn recover_eth_address(self: @T, msg_hash: u256, signature: Signature) -> (bool, EthAddress);

/// Performs signature verification in the secp256r1 ellipitic curve.
/// Performs signature verification in the secp256r1 elliptic curve.
///
/// # Arguments
///
Expand Down
4 changes: 2 additions & 2 deletions crates/contracts/src/kakarot_core/interface.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ pub trait IKakarotCore<TContractState> {
/// Gets the native token used by the Kakarot smart contract
fn get_native_token(self: @TContractState) -> ContractAddress;

/// Deterministically computes a Starknet address for an given EVM address
/// Deterministically computes a Starknet address for a given EVM address
/// The address is computed as the Starknet address corresponding to the deployment of an EOA,
/// Using its EVM address as salt, and KakarotCore as deployer.
fn compute_starknet_address(self: @TContractState, evm_address: EthAddress) -> ContractAddress;
Expand Down Expand Up @@ -59,7 +59,7 @@ pub trait IExtendedKakarotCore<TContractState> {
/// Gets the native token used by the Kakarot smart contract
fn get_native_token(self: @TContractState) -> ContractAddress;

/// Deterministically computes a Starknet address for an given EVM address
/// Deterministically computes a Starknet address for a given EVM address
/// The address is computed as the Starknet address corresponding to the deployment of an EOA,
/// Using its EVM address as salt, and KakarotCore as deployer.
fn compute_starknet_address(self: @TContractState, evm_address: EthAddress) -> ContractAddress;
Expand Down
2 changes: 1 addition & 1 deletion crates/evm/src/call_helpers.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ pub impl CallHelpersImpl of CallHelpers {
self.stack.push(0)?;
},
ExecutionResultStatus::Exception => {
// If the call has halted exceptionnaly,
// If the call has halted exceptionally,
// the return_data is emptied, and nothing is stored in memory
self.return_data = [].span();
self.stack.push(0)?;
Expand Down
2 changes: 1 addition & 1 deletion crates/evm/src/interpreter.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ pub impl EVMImpl of EVMTrait {
let mut sender_account = env.state.get_account(origin.evm);

// Charge the intrinsic gas to the sender so that it's not available for the execution
// of the transaction but don't trigger any actual transfer, as only the actual consumde
// of the transaction but don't trigger any actual transfer, as only the actual consumed
// gas is charged at the end of the transaction
sender_account.set_balance(sender_account.balance() - max_fee.into());

Expand Down
6 changes: 3 additions & 3 deletions docs/general/contract_storage.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ As Kakarot is a contract that is deployed on Starknet and is not a client that
can directly manipulate a storage database, our approach differs from one of a
traditional client. We do not directly manipulate tries. Instead, we have access
to contracts storage on the Starknet blockchain, that we can query using
syscalls to read and update the value of a of a storage slot.
syscalls to read and update the value of a storage slot.

There are two different ways of handling Storage in Kakarot.

Expand Down Expand Up @@ -105,7 +105,7 @@ This design has some limitations:

- We perform a `call_contract_syscall` for each SLOAD/SSTORE operation that is
committed to Starknet, which has an extra overhead compared to directly
modifying the current contract's storage . Given that only KakarotCore can
modifying the current contract's storage. Given that only KakarotCore can
modify the storage of a Kakarot contract, we could directly store the whole
world state in the main Kakarot contract storage.
- It adds external entrypoints with admin rights to read and write from storage
Expand Down Expand Up @@ -171,7 +171,7 @@ compatibility with Starknet.
### Tracking and reverting storage changes

The storage mechanism presented in the [Local State](./local_state.md) section
enable us to revert storage changes by using a concept similar to Geth's
enables us to revert storage changes by using a concept similar to Geth's
journal. Each storage change will be stored in a `StateChangeLog` implemented
using a `Felt252Dict` data structure, that will associate each modified storage
address to its new value. This allows us to perform three things:
Expand Down