-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: use with_base_fee
for TransactionInfo
#1069
Comments
Hello. Can i take this? |
Assigned |
@tcoratger hello sir. When this is included in the next release of reth, can you ping to work in this issue like the last time? |
Yes sure |
Pls assign, can complete within a day or less |
Assigned |
Made coinbase storage var a constructor argument rather than a hardcoded value. Time spent on this PR: 1 hour (methodology: searched the whole source tree for "coinbase", "0xCA40", "precompiles", and "uninitialized") ## Pull request type - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [X] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? Currently Coinbase is a hardcoded constant value (0xCA40796aFB5472abaeD28907D5ED6FC74c04954a) duplicated in a few places in the .py and .cairo sources. Resolves kkrt-labs#1011 ## What is the new behavior? That constant is now defined in a single location in constants.py and imported as needed. Accordingly, codebase is also passed as a new argument in the "kakarot" and "EVM" constructors. <!-- Reviewable:start --> - - - This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1069) <!-- Reviewable:end --> --------- Co-authored-by: Rene Doursat <[email protected]>
Describe the enhancement request
When alloy-rs/alloy#721 is included in the next release of reth (blocker at the moment), these lines
kakarot-rpc/src/tracing/mod.rs
Lines 68 to 69 in 338323f
with_base_fee
method that consumes theTransactionInfo
instance and populates it using the providedbase_fee
.The text was updated successfully, but these errors were encountered: