Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grep: force sh to be used for fzf preview command #5

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

TeddyDD
Copy link
Contributor

@TeddyDD TeddyDD commented Nov 12, 2021

Fixes kks-grep preview on non POSIX shells (Fish)

$SHELL variable is usually set to users preferred shell 1. If set,
FZF uses the variable to run preview command. kks-grep preview command
requires POSIX compatible shell.

Fixes kks-grep preview on non POSIX shells (Fish)

$SHELL variable is usually set to users preferred shell [1]. If set,
FZF uses the variable to run preview command. kks-grep preview command
requires POSIX compatible shell.

[1]: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03
Copy link
Owner

@kkga kkga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for contribution!

@kkga kkga merged commit df89306 into kkga:main Nov 12, 2021
@TeddyDD TeddyDD deleted the fix-grep-on-fish branch November 12, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants