Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustyline break some architecture on linux #731

Closed
eatradish opened this issue Sep 13, 2023 · 7 comments · Fixed by #736
Closed

rustyline break some architecture on linux #731

eatradish opened this issue Sep 13, 2023 · 7 comments · Fixed by #736
Labels

Comments

@eatradish
Copy link

eatradish commented Sep 13, 2023

The reason for this is that some of the terminal control constants in termios are wrong in some architectures, specifically at: dcuddeback/termios-rs#37 but it looks like the termios authors don't show up much anymore, rustlyline Is it possible to fix the problem on your own code? The solution is simple: change all variables like termios::VEOF to libc::VEOF

@gwenn
Copy link
Collaborator

gwenn commented Sep 13, 2023

Maybe we should rollback #717 ?

@eatradish
Copy link
Author

Maybe we should rollback #717 ?

Perhaps it could also be maintained by rustyline's author fork a termios? I'm not sure which is the better option

@gwenn
Copy link
Collaborator

gwenn commented Sep 14, 2023

Maybe we should rollback #717 ?

Perhaps it could also be maintained by rustyline's author fork a termios? I'm not sure which is the better option

I would prefer to put termios-rs behind an optional feature (and keep using nix by default as before).
(I suppose that you can activate termios-rs based on OS)

@gwenn gwenn added the bug label Oct 2, 2023
gwenn added a commit to gwenn/rustyline that referenced this issue Oct 6, 2023
@sunfishcode
Copy link

If you're interested, another option would be to use rustix's termios API, which doesn't have the issues of nix-rust/nix#2071 or dcuddeback/termios-rs#37.

@gwenn
Copy link
Collaborator

gwenn commented Oct 6, 2023

@sunfishcode
But possibly rustix specific issues...

@gwenn
Copy link
Collaborator

gwenn commented Oct 7, 2023

nix termios usages
=> 702
rustix termios usages
=> 36

@gwenn gwenn closed this as completed in #736 Oct 7, 2023
@gwenn
Copy link
Collaborator

gwenn commented Dec 5, 2023

Version 13.0.0 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants