Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the full test suite on GitHub actions #105

Merged
merged 3 commits into from
Oct 3, 2021
Merged

Run the full test suite on GitHub actions #105

merged 3 commits into from
Oct 3, 2021

Conversation

jdufresne
Copy link
Collaborator

GitHub actions now include:

  • Python 3.5
  • PyPy 3
  • mypy

Copy link
Collaborator

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like mypy is failing on pypy3

@jdufresne
Copy link
Collaborator Author

Thoughts on removing .travis.yml along with this change? Due to past Travis changes, it no longer runs. The same version of Python are now covered by GHA.

@sethmlarson
Copy link
Collaborator

Yeah let's do it. Goodbye, Travis.

GitHub actions now include:

- Python 3.5
- PyPy 3
- mypy
@jdufresne
Copy link
Collaborator Author

looks like mypy is failing on pypy3

Fixed in latest. I've excluded pypy3 from mypy as the typed-ast package doesn't support PyPy. See the following thread for more details:

python/typed_ast#111

Yeah let's do it. Goodbye, Travis.

Done in latest 😁

Copy link
Collaborator

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @kjd you'll have to add the GHA commit statuses and remove Travis from the branch.

@kjd kjd merged commit c3383c9 into kjd:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants