Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Server::setAddress #1151

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix Server::setAddress #1151

merged 1 commit into from
Oct 9, 2024

Conversation

sgourdas
Copy link
Collaborator

@sgourdas sgourdas commented Oct 9, 2024

This brings a change from the closed #1147 that fixes multiple uses of Server::setAddress.

Now the m_addr field is cleared before setting a new ip.

Helps a lot especially in kiwix-desktop local server, when multiple servers may be started.

Fixes #1150

@sgourdas
Copy link
Collaborator Author

sgourdas commented Oct 9, 2024

@kelson42 would be good to include this in the 14 release as well. It is a small fix.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.47%. Comparing base (c8bddd6) to head (8b00c2e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
+ Coverage   41.45%   41.47%   +0.02%     
==========================================
  Files          59       59              
  Lines        4270     4272       +2     
  Branches     2336     2336              
==========================================
+ Hits         1770     1772       +2     
  Misses        999      999              
  Partials     1501     1501              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 merged commit 585f55d into main Oct 9, 2024
12 of 15 checks passed
@kelson42 kelson42 deleted the feature/fix-server-set-addr branch October 9, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server::setAddress cannot be used more than once for an object
3 participants