Implement portable mode

[sgourdas]

This adds a check for the .portable file besides the executable. If it exists all application files will be saved in the data directory.

Fixes #1166

[kelson42]

@sgourdas What is exactly the status here? It is mark ready to review, but still WIP and no reviewer? It's unclear.

[sgourdas]

Changing to draft since getDataDirectory is not merged yet. I have finished work on the others.

[kelson42]

@sgourdas If there is a blocker, please write it clearly. Now that the data directory PR are merge, does that mean this PR is ready to review?
@sgourdas Please rebase an fix conflict.

[sgourdas]

Rebased with main and completed changes. Ready for review.

[veloman-yunkan]

WIP qualifier is no longer pertinent, I guess

[kelson42]

@sgourdas Sorry for the lack of feedback here, will look ASAP

[kelson42]

I have checked finally your feature. This is on the good way, but it seems that the configuration is still take from the older "system" conf.

I see also no kiwix-desktop.conf in the data directory. Please verify that all configuration files from https://github.com/kiwix/kiwix-desktop/wiki/Data-and-Configuration-Files are read/write locally. Please update https://github.com/kiwix/kiwix-desktop/wiki/Data-and-Configuration-Files with a new "portable" column as well.

[kelson42]

@sgourdas Any update?

[sgourdas]

Sorry for the delay. I will update ASAP.

[kelson42]

@sgourdas Please ensure this PR fixes #460 properly

[sgourdas]

Please update https://github.com/kiwix/kiwix-desktop/wiki/Data-and-Configuration-Files with a new "portable" column as well.

@kelson42 what should the "portable" column have as information?

[kelson42]

Please update https://github.com/kiwix/kiwix-desktop/wiki/Data-and-Configuration-Files with a new "portable" column as well.

@kelson42 what should the "portable" column have as information?

The relative paths where the file are read/written

[sgourdas]

Please update https://github.com/kiwix/kiwix-desktop/wiki/Data-and-Configuration-Files with a new "portable" column as well.

@kelson42 what should the "portable" column have as information?

The relative paths where the file are read/written

I have set it up so in portable mode all files are written in the data folder besides the executable. Since it is all the same maybe just a note under the table would be enough?

[sgourdas]

@veloman-yunkan I added support also for the download directory and .conf file to work appropriately in portable mode.

[kelson42]

To me, this PR seems to perfctly implement #1166

@veloman-yunkan This is ready for the code review

[veloman-yunkan]

Regarding the current changes I have only a couple of insignificant proposals for improvement.

But regarding the portable functionality I have the following questions:

1. Should we allow the user to change/set the download and monitored directories in portable mode?
2. Should we allow adding ZIM files from outside the USB drive to the library in portable mode?

[sgourdas]

But regarding the portable functionality I have the following questions:

1. Should we allow the user to change/set the download and monitored directories in portable mode?
2. Should we allow adding ZIM files from outside the USB drive to the library in portable mode?

I was thinking about this too and how strict we should be with the portable mode.

IMO we should not be very restrictive and let the user choose. But, with the current implementation, if the download directory is changed and mode is portable, it would be set back to the data folder on app restart, which I dont think is proper, but adds some complexity if we want to tackle.

[veloman-yunkan]

But, with the current implementation, if the download directory is changed and mode is portable, it would be set back to the data folder on app restart

How come it works like that? Isn't the download directory setting saved in the kiwix-desktop.session file?

[veloman-yunkan]

LGTM.

[sgourdas]

But, with the current implementation, if the download directory is changed and mode is portable, it would be set back to the data folder on app restart

How come it works like that? Isn't the download directory setting saved in the kiwix-desktop.session file?

It does usually, but not in portable mode as per this PR.

settingsmanager.cpp:192

[kelson42]

1. Should we allow the user to change/set the download and monitored directories in portable mode?

Why not? But to me this is something different: I have created #1203

I believe that per default, the data directory should be monitored, see my comment.

2. Should we allow adding ZIM files from outside the USB drive to the library in portable mode?

Why, not? At the end this is also a topic which is relevant for #1203 IMHO