Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid building and installing curl executable #778

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

veloman-yunkan
Copy link
Collaborator

Fixes #777

We only need the libcurl library. Building and installing the curl tool leads to a build failure under Windows because of a missing strip utility.

@kelson42
Copy link
Contributor

@veloman-yunkan No super happy because if I understand right, this is removed everywhere although this is a Windows only problem! Consequence will be size increase of all binaries (not only on Windows).

We only need the libcurl library. Building and installing the curl tool
leads to a build failure under Windows because of a missing "strip"
utility.
@kelson42 kelson42 merged commit 83b45a0 into main Nov 26, 2024
40 checks passed
@kelson42 kelson42 deleted the libcurl_toolless_build branch November 26, 2024 13:38
@veloman-yunkan
Copy link
Collaborator Author

@veloman-yunkan No super happy because if I understand right, this is removed everywhere although this is a Windows only problem! Consequence will be size increase of all binaries (not only on Windows).

Why would the size of any binary increase because of this change? This fix only tells the build system not to build the curl executable which we don't need at all.

@kelson42
Copy link
Contributor

@veloman-yunkan No super happy because if I understand right, this is removed everywhere although this is a Windows only problem! Consequence will be size increase of all binaries (not only on Windows).

Why would the size of any binary increase because of this change? This fix only tells the build system not to build the curl executable which we don't need at all.

Was a fundamental misunderstanding my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems building kiwix-desktop in release mode
2 participants