Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing symbols on CoreKiwix.xcframework #765

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Fix missing symbols on CoreKiwix.xcframework #765

merged 3 commits into from
Oct 17, 2024

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    c58b209 View commit details
    Browse the repository at this point in the history
  2. Disable libpsl when compiling libcurl

    libpsl is a lib that provides the Public Suffix List: the list
    of all TLDs.
    It's an optional feature of libcurl that we dont need for libkiwix.
    
    Leaving it included causes issues when compiling for apple_all_static
    on x86_64 as libpsf is installed (and thus found by libcurl's configure)
    but is obviously only for x86_64.
    
    An alternative could be to either cross-compile it first and properly
    reference that version.
    
    That sounds like too much effort for a feature we know we dont need.
    
    https://github.com/rockdaboot/libpsl
    rgaudin committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    74767e6 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Configuration menu
    Copy the full SHA
    59778f4 View commit details
    Browse the repository at this point in the history