-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Not able to upload 512MB+ custom apps anymore. #3801
Conversation
@MohitMaliFtechiz Thx for rhis PR, but its important to notice that we won't be able to put more than 3 chunks=1.5GB as asset. It does not fully fix the problem AFAIK |
@kelson42 We have a total combined limit of |
db9761b
to
932ac55
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3801 +/- ##
============================================
- Coverage 53.57% 53.53% -0.04%
+ Complexity 1399 1398 -1
============================================
Files 301 301
Lines 11556 11564 +8
Branches 1521 1523 +2
============================================
Hits 6191 6191
- Misses 4371 4377 +6
- Partials 994 996 +2 ☔ View full report in Codecov by Sentry. |
@MohitMaliFtechiz What is missing here to complete this PR? |
@kelson42 The testing of this PR is missing(uploading to the playStore). I am on the way to testing the |
* Introduced the splitting zim file with 500MB for custom apps. Since the bundle has a limit for a file to upload it uses the play asset delivery mode, and for new custom apps, playStore does not allow to upload the apk (with apk we can upload more than 1GB file). So to address this issue we have introduced a feature in libzim where we can load the zim files via the fd list. * We have modified our code to upload the files with 500MB chunks in the asset folder, and later we are accessing these files from the asset folder and creating the archive object with the help of the new libzim feature.
* It was not showing the article when fresh application is installed on device with list of fds, and after the first install it works normally(It starts loading the article). So we have placed a fix for this.
e192c88
to
10f4f24
Compare
For now, only install-time. |
@kelson42 I have tested the uploading of the I also tested uploading aab files larger than 1.5GB. I successfully uploaded a 1.52GB aab file to PlayStore. However, I have not fully tested it because the ZIM chunks were made from different files, and I don't have a single ZIM file between 1.5GB and 2GB. Downloading large files from the server taking too long(it almost took me 4-5 hours and still downloading is not completed). Nevertheless, the file uploaded successfully under the install-time delivery mode, and the size displayed during download is over 1.5GB, so we can assume it will be available immediately after downloading the application. We will test this scenario while uploading the |
Fixes #3511
java-libkiwix
is not released once the new binding is released and we start using that then this error will resolve.