Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Create only one reader and use it everywhere. #3624

Merged
merged 19 commits into from
Aug 26, 2024

* Fixed: Deleting files was not working in the local library.

2d0bc48
Select commit
Loading
Failed to load commit list.
Merged

Fixed: Create only one reader and use it everywhere. #3624

* Fixed: Deleting files was not working in the local library.
2d0bc48
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Aug 25, 2024 in 1s

42.85% of diff hit (target 70.00%)

View this Pull Request on Codecov

42.85% of diff hit (target 70.00%)

Annotations

Check warning on line 223 in app/src/main/java/org/kiwix/kiwixmobile/main/KiwixMainActivity.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/org/kiwix/kiwixmobile/main/KiwixMainActivity.kt#L223 

Added line #L223 was not covered by tests

Check warning on line 411 in app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/LocalLibraryFragment.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/LocalLibraryFragment.kt#L410-L411 

Added lines #L410 - L411 were not covered by tests

Check warning on line 413 in app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/LocalLibraryFragment.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/org/kiwix/kiwixmobile/nav/destination/library/LocalLibraryFragment.kt#L413 

Added line #L413 was not covered by tests

Check warning on line 343 in app/src/main/java/org/kiwix/kiwixmobile/nav/destination/reader/KiwixReaderFragment.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/org/kiwix/kiwixmobile/nav/destination/reader/KiwixReaderFragment.kt#L343 

Added line #L343 was not covered by tests

Check warning on line 33 in app/src/main/java/org/kiwix/kiwixmobile/zimManager/fileselectView/effects/OpenFileWithNavigation.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/org/kiwix/kiwixmobile/zimManager/fileselectView/effects/OpenFileWithNavigation.kt#L33 

Added line #L33 was not covered by tests

Check warning on line 40 in app/src/main/java/org/kiwix/kiwixmobile/zimManager/fileselectView/effects/OpenFileWithNavigation.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/org/kiwix/kiwixmobile/zimManager/fileselectView/effects/OpenFileWithNavigation.kt#L38-L40 

Added lines #L38 - L40 were not covered by tests

Check warning on line 33 in app/src/main/java/org/kiwix/kiwixmobile/zimManager/fileselectView/effects/ShareFiles.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/src/main/java/org/kiwix/kiwixmobile/zimManager/fileselectView/effects/ShareFiles.kt#L33 

Added line #L33 was not covered by tests

Check warning on line 38 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/HistoryDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/HistoryDao.kt#L37-L38 

Added lines #L37 - L38 were not covered by tests

Check warning on line 43 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/HistoryDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/HistoryDao.kt#L42-L43 

Added lines #L42 - L43 were not covered by tests

Check warning on line 45 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/HistoryDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/HistoryDao.kt#L45 

Added line #L45 was not covered by tests

Check warning on line 47 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/HistoryDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/HistoryDao.kt#L47 

Added line #L47 was not covered by tests

Check warning on line 44 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/HistoryRoomDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/HistoryRoomDao.kt#L43-L44 

Added lines #L43 - L44 were not covered by tests

Check warning on line 308 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/LibkiwixBookmarks.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/LibkiwixBookmarks.kt#L308 

Added line #L308 was not covered by tests

Check warning on line 338 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/LibkiwixBookmarks.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/LibkiwixBookmarks.kt#L334-L338 

Added lines #L334 - L338 were not covered by tests

Check warning on line 420 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/LibkiwixBookmarks.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/LibkiwixBookmarks.kt#L420 

Added line #L420 was not covered by tests

Check warning on line 40 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt#L40 

Added line #L40 was not covered by tests

Check warning on line 51 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt#L51 

Added line #L51 was not covered by tests

Check warning on line 53 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt#L53 

Added line #L53 was not covered by tests

Check warning on line 55 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt#L55 

Added line #L55 was not covered by tests

Check warning on line 58 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt#L57-L58 

Added lines #L57 - L58 were not covered by tests

Check warning on line 103 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt#L103 

Added line #L103 was not covered by tests

Check warning on line 116 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookDao.kt#L116 

Added line #L116 was not covered by tests

Check warning on line 39 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookmarksDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookmarksDao.kt#L38-L39 

Added lines #L38 - L39 were not covered by tests

Check warning on line 44 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookmarksDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookmarksDao.kt#L43-L44 

Added lines #L43 - L44 were not covered by tests

Check warning on line 46 in core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookmarksDao.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/src/main/java/org/kiwix/kiwixmobile/core/dao/NewBookmarksDao.kt#L46 

Added line #L46 was not covered by tests
View more details on Codecov