Removed the fetch library from README file.

* Also, now we are not using fetch library anymore so we have removed this from our credits files. * Removed the unused code from detekt_baseline.xml file.
kiwix · Aug 12, 2024 · c9b4311 · c9b4311
1 parent a267ae8
commit c9b4311
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 20 deletions.
diff --git a/README.md b/README.md
@@ -96,8 +96,6 @@ are interested in our custom apps, they have their own repo
   classes by default.
 - [JUnit5](https://github.com/junit-team/junit5/) - The next generation of JUnit
 - [AssertJ](https://github.com/joel-costigliola/assertj-core) - Fluent assertions for test code
-- [Fetch](https://github.com/tonyofrancis/Fetch) - A customizable file download manager library for
-  Android
 - [ZXing](https://github.com/zxing/zxing) - Barcode scanning library for Java, Android
 
 ## Contributing

diff --git a/app/src/main/assets/credits.html b/app/src/main/assets/credits.html
@@ -77,11 +77,6 @@ <h3>Apache</h3>
         <br/>
         Copyright 2013 Evan Tatarka
     </li>
-    <li>
-        <b>Fetch</b>
-        <br/>
-        Copyright (C) 2017 Tonyo Francis
-    </li>
     <li>
         <b>ObjectBox</b>
         <br/>

diff --git a/core/detekt_baseline.xml b/core/detekt_baseline.xml
@@ -3,7 +3,6 @@
   <ManuallySuppressedIssues/>
   <CurrentIssues>
     <ID>EmptyFunctionBlock:BooksOnDiskViewHolder.kt$BookOnDiskViewHolder.BookViewHolder${ }</ID>
-    <ID>EmptyFunctionBlock:FetchDownloadMonitor.kt$FetchDownloadMonitor.&lt;no name provided>${}</ID>
     <ID>EmptyFunctionBlock:OnSwipeTouchListener.kt$OnSwipeTouchListener${}</ID>
     <ID>ForbiddenComment:JNIInitialiser.kt$JNIInitialiser$// TODO: Consider surfacing to user</ID>
     <ID>ForbiddenComment:NetworkUtilsTest.kt$NetworkUtilsTest$// TODO: find a way to assert regex matching via JUnit and rewrite the test</ID>
@@ -20,8 +19,6 @@
     <ID>MagicNumber:DownloadItem.kt$DownloadItem$1000L</ID>
     <ID>MagicNumber:SearchState.kt$SearchState$100</ID>
     <ID>MagicNumber:DownloaderModule.kt$DownloaderModule$5</ID>
-    <ID>MagicNumber:FetchDownloadNotificationManager.kt$FetchDownloadNotificationManager$100</ID>
-    <ID>MagicNumber:FetchDownloadRequester.kt$10</ID>
     <ID>MagicNumber:FileUtils.kt$FileUtils$3</ID>
     <ID>MagicNumber:JNIInitialiser.kt$JNIInitialiser$1024</ID>
     <ID>MagicNumber:KiloByte.kt$KiloByte$1024.0</ID>

diff --git a/core/src/main/java/org/kiwix/kiwixmobile/core/di/modules/ApplicationModule.kt b/core/src/main/java/org/kiwix/kiwixmobile/core/di/modules/ApplicationModule.kt
@@ -88,11 +88,6 @@ class ApplicationModule {
   @Provides
   fun provideComputationThread(): Scheduler = Schedulers.computation()
 
-  // @Provides
-  // @Singleton
-  // internal fun provideDownloadMonitor(fetchDownloadMonitor: FetchDownloadMonitor): DownloadMonitor =
-  //   fetchDownloadMonitor
-
   @Provides
   @Singleton
   internal fun provideDownloadMonitor(

diff --git a/custom/src/main/assets/credits.html b/custom/src/main/assets/credits.html
@@ -78,11 +78,6 @@ <h3>Apache</h3>
         <br/>
         Copyright 2013 Evan Tatarka
     </li>
-    <li>
-        <b>Fetch</b>
-        <br/>
-        Copyright (C) 2017 Tonyo Francis
-    </li>
     <li>
         <b>ObjectBox</b>
         <br/>