Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KiwiUrls#prependLeadingSlash should accept empty strings #1107

Merged
merged 1 commit into from
Mar 5, 2024
Merged

KiwiUrls#prependLeadingSlash should accept empty strings #1107

merged 1 commit into from
Mar 5, 2024

Conversation

sleberknight
Copy link
Member

Closes #1106

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chrisrohr chrisrohr merged commit 3d62c4f into master Mar 5, 2024
5 checks passed
@chrisrohr chrisrohr deleted the 1106-fix-prependLeadingSlash-for-empty-strings branch March 5, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrohr chrisrohr chrisrohr approved these changes

@dsingley dsingley Awaiting requested review from dsingley

@terezivy terezivy Awaiting requested review from terezivy

Assignees

@chrisrohr chrisrohr

@dsingley dsingley

@sleberknight sleberknight

@terezivy terezivy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KiwiUrls#prependLeadingSlash should accept empty or white space-only strings
4 participants
@sleberknight @chrisrohr @dsingley @terezivy