Fix flaky tests in AsyncTest #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This relates to #1070 Pretty sure it has nothing to do with ForkJoinPool init time and that it is due to tasks from previous tests that used the common pool and which are still executing and blocking the new tests...which then causes them to exceed the timeout and fail |
sleberknight
changed the title
|
I don't really understand why this only happens when running in GitHub actions - I'm using the same JDK on my laptop and when using Gitpod, so only thing I can think of is differences in the JVM behavior on different operating systems, e.g. on my MacBook Pro versus in Gitpod versus in GitHub Actions. |
* Replace hard-coded test names by using TestInfo in setUp * Delete the commented-out code * Remove logging from shouldTimeout_WhenTaskTakesLongerThan_MaxTimeout in WithMaxTimeout nested class; I realized that above those we wait until the future with timeout has completed exceptionally, so the logs were not helpful
Wrap assertions in a try and cancel in a finally
Of course, they always pass when running locally on my MacBook Pro or even in Gitpod. I don't get why I can never make them fail locally, but they consistently fail when running in GitHib actions without the cancellations.
* Remove the RetryingTest annotations * Remove javadocs on formerly retrying tests, since they are no longer retrying tests (and we hope now always pass in GitHub actions where they were flaky)
sleberknight
commented
Nov 17, 2023
sleberknight
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the tests all pass consistently by canceling the futures in the tests
where we expect to timeout before the tasks complete. Without canceling them,
tests which call methods in Async that use the common ForkJoinPool can be
blocked by tasks that are still executing from previous tests! So, in the three tests
where waitFor/waitForAll/waitForAllIgnoringTypes time out before the tasks complete,
wrap the assertions in a try/finally and cancel the futures in the finally block. This
commit also removes the RetryingTest annotations on the four tests which had them
and replaces them with the standard JUnit Test annotation. Hopefully this will be
the last time we ever need to deal with flaky tests in Async.
Closes #1070