Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flaky test in AsyncTest a "retrying test" #1072

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

sleberknight
Copy link
Member

@sleberknight sleberknight commented Nov 15, 2023

Hopefully temporary, but change
shouldSucceed_WhenTheFutureCompletes_BeforeTimeout to a RetryingTest so that it (hopefully) will consistently pass when running in GitHub actions.

Relates to #1070

Hopefully temporary, but change
shouldSucceed_WhenTheFutureCompletes_BeforeTimeout
to a RetryingTest so that it (hopefully) will consistently
pass when running in GitHub actions.

Relatest to #1070
@sleberknight sleberknight self-assigned this Nov 15, 2023
@sleberknight sleberknight linked an issue Nov 15, 2023 that may be closed by this pull request
@sleberknight sleberknight added this to the 3.1.1 milestone Nov 15, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sleberknight sleberknight merged commit 2f96e45 into master Nov 15, 2023
6 checks passed
@sleberknight sleberknight deleted the 107-make-flaky-test-a-RetryingTest-for-now branch November 15, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate flaky test in AsyncTest
1 participant