Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated #getCommandParts methods from VaultXxxCommand classes ⛔ #1034

Closed
sleberknight opened this issue Aug 27, 2023 · 0 comments · Fixed by #1131
Closed

Remove deprecated #getCommandParts methods from VaultXxxCommand classes ⛔ #1034

sleberknight opened this issue Aug 27, 2023 · 0 comments · Fixed by #1131
Assignees
@sleberknight
Labels
API change Change to a public API
Milestone
4.0.0

Comments

@sleberknight
Copy link
Member

Remove all the getCommandParts() methods from the VaultXxxCommand classes. They are deprecated for removal and have a replacement, the parts() method defined by the org.kiwiproject.base.process.OsCommand interface which replaced the original org.kiwiproject.ansible.vault.OsCommand class (which is also deprecated for removal).

References:
@sleberknight sleberknight added the API change Change to a public API label Aug 27, 2023
@sleberknight sleberknight added this to the 4.0.0 milestone Aug 27, 2023
@sleberknight sleberknight changed the title Remove deprecated #getCommandParts methods from VaultXxxCommand classes Remove deprecated #getCommandParts methods from VaultXxxCommand classes ⛔ Aug 27, 2023
@sleberknight sleberknight self-assigned this Apr 28, 2024
sleberknight added a commit that referenced this issue May 1, 2024
@sleberknight
Remove deprecated #getCommandParts methods from VaultXxxCommand class…
8c87490 
…es ⛔

* Remove deprecated #getCommandPart
* Remove assertions in tests

Closes #1034
@sleberknight sleberknight mentioned this issue May 1, 2024
Merged
sleberknight added a commit that referenced this issue May 1, 2024
@sleberknight
Remove deprecated #getCommandParts methods from VaultXxxCommand class…
bac9a00 
…es ⛔ (#1131)

* Remove deprecated #getCommandParts methods
* Remove assertions in tests

Closes #1034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
API change Change to a public API
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Remove deprecated #getCommandParts methods from VaultXxxCommand classes ⛔ kiwiproject/kiwi
1 participant
@sleberknight