Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code using mongo-java-server to use 4.0 and wire protocol 7 #539

Closed
sleberknight opened this issue Jan 2, 2025 · 0 comments · Fixed by #540
Closed

Update code using mongo-java-server to use 4.0 and wire protocol 7 #539

sleberknight opened this issue Jan 2, 2025 · 0 comments · Fixed by #540
Assignees
@sleberknight
Labels
enhancement A request for change or improvement to an existing feature
Milestone
3.8.0

Comments

@sleberknight
Copy link
Member

⚠️ This cannot be implemented until mongo-java-server is updated from 1.45.0 to 1.46.0 in kiwi-bom and it is released in 2.0.19

I think these are the only locations that need to change:

  • MongoServerTests#startInMemoryMongoServer() should change to use the new ServerVersion.MONGO_4_0 constant (which supports wire protocol 7).
  • Update the Javadoc in MongoServerTests to reflect the above change to use MONGO_4_0 as the default.
  • Change MongoServerExtension to use ServerVersion.MONGO_4_0.
  • Update Javadocs in MongoServerExtension to remove the warning added in 3.7.0, and to change all places where 3.6 is referenced to 4.0.
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Jan 2, 2025
@sleberknight sleberknight added this to the 3.8.0 milestone Jan 2, 2025
@sleberknight sleberknight added the blocked Blocked by another issue, PR, etc. label Jan 2, 2025
@sleberknight sleberknight mentioned this issue Jan 2, 2025
Merged
sleberknight added a commit that referenced this issue Jan 3, 2025
@sleberknight
Update mongo-java-server code to Mongo server 4.0, wire version 7
fd74758 
* Update MongoServerExtension to use ServerVersion.MONGO_4_0 as
  the default, so that it can work with Mongo driver 5.2.0 and
  higher versions.
* Update MongoServerTests to use ServerVersion.MONGO_4_0 as
  the default in the no-args startInMemoryMongoServer().
* Update Javadocs in MongoServerExtension and MongoServerTests.
* Lock the required version of mongo-java-server to 1.46.0
  in the POM until kiwi-bom 2.0.19 is released.

Closes #539
@sleberknight sleberknight mentioned this issue Jan 3, 2025
Merged
@sleberknight sleberknight removed the blocked Blocked by another issue, PR, etc. label Jan 4, 2025
@sleberknight sleberknight self-assigned this Jan 4, 2025
@sleberknight sleberknight mentioned this issue Jan 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

Update mongo-java-server code to Mongo server 4.0, wire version 7 kiwiproject/kiwi-test
1 participant
@sleberknight