Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make InMemoryAppenderExtension a public part of kiwi-test #448

Closed
sleberknight opened this issue Dec 17, 2023 · 0 comments · Fixed by #450
Closed

Make InMemoryAppenderExtension a public part of kiwi-test #448

sleberknight opened this issue Dec 17, 2023 · 0 comments · Fixed by #450
Assignees
@sleberknight
Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Milestone
3.2.0

Comments

@sleberknight
Copy link
Member

Currently InMemoryAppenderExtension is only in the test sources.

Initially it will be marked with @Beta.
@sleberknight sleberknight added the new feature A new feature such as a new class, method, package, group of classes, etc. label Dec 17, 2023
@sleberknight sleberknight added this to the 3.2.0 milestone Dec 17, 2023
@sleberknight sleberknight self-assigned this Dec 17, 2023
sleberknight added a commit that referenced this issue Dec 23, 2023
@sleberknight
Make in-memory appender classes part of the public API
d741f87 
* Move InMemoryAppender, InMemoryAppenderAssertions, and
  InMemoryAppenderExtension to the production sources.
* Enhance the javadocs for these classes.
* Add new assertThatAppender entry point to
  InMemoryAppenderAssertions to avoid static import
  conflicts with AssertJ's Assertions#assertThat.
* Remove assertNumberOfLoggingEventsAndGet from InMemoryAppender
  because there are two methods in InMemoryAppenderAssertions
  that already provide this functionality.
* Change logback-classic to be a provided dependency.

Closes #447
Closes #448
Closes #449
@sleberknight sleberknight mentioned this issue Dec 23, 2023
Merged
sleberknight added a commit that referenced this issue Dec 23, 2023
@sleberknight
Make in-memory appender classes part of the public API (#450)
81c6fd7 
* Move InMemoryAppender, InMemoryAppenderAssertions, and
  InMemoryAppenderExtension to the production sources.
* Enhance the javadocs for these classes.
* Add new assertThatAppender entry point to
  InMemoryAppenderAssertions to avoid static import
  conflicts with AssertJ's Assertions#assertThat.
* Remove assertNumberOfLoggingEventsAndGet from InMemoryAppender
  because there are two methods in InMemoryAppenderAssertions
  that already provide this functionality.
* Change logback-classic to be a provided dependency.

Closes #447
Closes #448
Closes #449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Projects
None yet
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

Make in-memory appender classes part of the public API kiwiproject/kiwi-test
1 participant
@sleberknight