Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of deprecated Liquibase#update(Contexts) method in H2LiquibaseExtension #389

Closed
sleberknight opened this issue May 1, 2023 · 1 comment · Fixed by #406
Closed
Assignees
Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Milestone

Comments

@sleberknight
Copy link
Member

sleberknight commented May 1, 2023

Liquibase has deprecated a bunch of the update methods (as well as many rollback methods). We need to find a replacement.

Note that this indirectly affects PostgresLiquibaseTestExtension, because it uses the PreparedDbExtension from the Zonky embedded-postgres library, which uses the same deprecated Liquibase#update method in the LiquibasePreparer class.

I tried using a few of the non-deprecated update methods and they didn't work, because it seems they did not actually perform the database update! e.g. I tried update(Contexts contexts, Writer output) and update(Contexts contexts, LabelExpression labelExpression, Writer output). The documentation is non-existent on the Liquibase#update methods that are not deprecated, i.e. they have no javadocs. And, the deprecated methods don't tell you anything about what the replacement is, so this is going to take some work.

@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label May 1, 2023
@sleberknight sleberknight added this to the 2.3.3 milestone May 1, 2023
@sleberknight sleberknight self-assigned this May 1, 2023
@sleberknight sleberknight removed this from the 2.3.3 milestone May 1, 2023
@sleberknight
Copy link
Member Author

sleberknight commented Jul 25, 2023

A few references I found (none of which are currently sufficient to make this easy...):

@sleberknight sleberknight added this to the 2.4.0 milestone Jul 25, 2023
sleberknight added a commit that referenced this issue Jul 25, 2023
* Replace  deprecated Liquibase#update method with the
  new Command API

Closes #389
dsingley pushed a commit that referenced this issue Jul 25, 2023
)

* Replace  deprecated Liquibase#update method with the
  new Command API

Closes #389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant