Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit JDBI3 dependencies to the BOM #63

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

sleberknight
Copy link
Member

  • jdbi3-core
  • jdbi3-guava
  • jdbi3-jodatime2

Fixes #62

* jdbi3-core
* jdbi3-guava
* jdbi3-jodatime2

Fixes #62
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sleberknight
Copy link
Member Author

@chrisrohr Note I tested this locally against kiwi and dropwizard-application-errors, which are the kiwi projects that use JDBI directly. Note also that I added jdbi3-guava and jdbi3-jodatime2 because I noticed that dropwizard-jdbi3 directly depends on those as well, so adding them makes all the JDBI versions consistent.

@chrisrohr chrisrohr merged commit f7a58e1 into master Jan 7, 2022
@chrisrohr chrisrohr deleted the 62-add-jdbi3-explicit-dependencies branch January 7, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add jdbi3-core, -guava, -jodatime2 to prevent dependency convergence errors downstream
2 participants