Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonar cleanup (2024-07-08) #518

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Sonar cleanup (2024-07-08) #518

merged 1 commit into from
Jul 8, 2024

Conversation

sleberknight
Copy link
Member

Fix five "new" issues that Sonar just flagged.

  • Add comment to empty methods in test classes (MyDynamicPortsApp, MyStartupLockApp)
  • Remove no-args constructor from TestApp in ConfigResourceTest
  • Rename non-static fields in nested test classes in StartupLockerTest so they are idiomatic: camelCase, not UPPER_SNAKE_CASE.

Fix five "new" issues that Sonar just flagged.

* Add comment to empty methods in test classes
  (MyDynamicPortsApp, MyStartupLockApp)
* Remove no-args constructor from TestApp in ConfigResourceTest
* Rename non-static fields in nested test classes in StartupLockerTest
  so they are idiomatic: camelCase, not UPPER_SNAKE_CASE.
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Jul 8, 2024
@sleberknight sleberknight added this to the 3.7.1 milestone Jul 8, 2024
@sleberknight sleberknight self-assigned this Jul 8, 2024
Copy link

sonarqubecloud bot commented Jul 8, 2024

@sleberknight sleberknight merged commit e2ffb99 into main Jul 8, 2024
5 checks passed
@sleberknight sleberknight deleted the sonar-cleanup branch July 8, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant