Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc code cleanup #477

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Misc code cleanup #477

merged 1 commit into from
Apr 28, 2024

Conversation

sleberknight
Copy link
Member

  • Organize imports in several classes.
  • Replace custom methods with new utilities from kiwi in DynamicPortsConfiguration and StartupLockConfiguration.
  • Fix missing return javadoc tag in PortAssigner.
  • Remove (now) redundant cast in MyStartupLockApp.
  • Make StartupLocker field final in MyStartupLockApp.
  • Extract duplicate code in JobErrorHandlersTest into method.

@sleberknight
Misc code cleanup
42197d4 
* Organize imports in several classes.
* Replace custom methods with new utilities from kiwi in
  DynamicPortsConfiguration and StartupLockConfiguration.
* Fix missing return javadoc tag in PortAssigner.
* Remove (now) redundant cast in MyStartupLockApp.
* Make StartupLocker field final in MyStartupLockApp.
* Extract duplicate code in JobErrorHandlersTest into method.
@sleberknight sleberknight added code cleanup Fix issues reported by Sonar or any other code analysis tools documentation Improvements or additions to documentation labels Apr 28, 2024
@sleberknight sleberknight added this to the 3.5.0 milestone Apr 28, 2024
@sleberknight sleberknight self-assigned this Apr 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sleberknight sleberknight merged commit 4477f7d into main Apr 28, 2024
5 checks passed
@sleberknight sleberknight deleted the misc-code-cleanup branch April 28, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sleberknight sleberknight

Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools documentation Improvements or additions to documentation
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@sleberknight