Make newScheduledExecutor public and move to StandardLifecycles #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move newScheduledExecutor from MonitoredJobs to StandardLifecycles * Update the javadocs in StandardLifecycles since it is no longer just about setting up lifecycle listeners * Since MonitoredJobsTest and StandardLifecyclesTest had the same code to shut down the ScheduledExecutorService, moved that code into a new shared test utility, TestExecutors, which ensures the executor is gracefully shut down once the test is finished with it Closes #109
|
Kudos, SonarCloud Quality Gate passed! |
chrisrohr
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
about setting up lifecycle listeners
to shut down the ScheduledExecutorService, moved that code into a
new shared test utility, TestExecutors, which ensures the executor
is gracefully shut down once the test is finished with it
Closes #109