Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default name constants to relevant health checks #87

Closed
sleberknight opened this issue Jan 12, 2021 · 0 comments · Fixed by #88
Closed

Add default name constants to relevant health checks #87

sleberknight opened this issue Jan 12, 2021 · 0 comments · Fixed by #88
Assignees
Labels
enhancement A request for change or improvement to an existing feature
Milestone

Comments

@sleberknight
Copy link
Member

HttpConnectionsHealthCheck has a DEFAULT_NAME constant that can be used as the default name when registering it as a health check in a Dropwizard application.

Since we use many of the other health checks a lot, we should add DEFAULT_NAME to them as well. The ones we should include are:

  • MongoHealthCheck (rename existing TITLE constant)
  • ProcessGrepHealthCheck
  • ProcessKillHealthCheck
  • ProcessLaunchHealthCheck
  • ServerErrorHealthCheck
  • UnknownPropertiesHealthCheck
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Jan 12, 2021
@sleberknight sleberknight added this to the 0.4.0 milestone Jan 12, 2021
@sleberknight sleberknight self-assigned this Jan 12, 2021
sleberknight added a commit that referenced this issue Jan 12, 2021
chrisrohr pushed a commit that referenced this issue Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant