Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LocalPortChecker from PortAssigner #546

Closed
sleberknight opened this issue Oct 16, 2024 · 0 comments · Fixed by #548
Closed

Remove LocalPortChecker from PortAssigner #546

sleberknight opened this issue Oct 16, 2024 · 0 comments · Fixed by #548
Assignees
@sleberknight
Labels
API change Change to a public API
Milestone
4.0.0

Comments

@sleberknight
Copy link
Member

Remove the LocalPortChecker from PortAssigner, since FreePortFinder replaces it completely.

This causes the public API to change, and is therefore a breaking change.

See this comment for details.
@sleberknight sleberknight added the API change Change to a public API label Oct 16, 2024
@sleberknight sleberknight added this to the 4.0.0 milestone Oct 16, 2024
@sleberknight sleberknight self-assigned this Oct 16, 2024
sleberknight added a commit that referenced this issue Oct 17, 2024
@sleberknight
Enhance dynamic ports bundle and FreePortFinder
212ce22 
* Configure a FreePortFinder when creating the PortAssigner
  inside DynamicPortsBundle.
* Remove LocalPortChecker from DynamicPortsConfiguration.
* Add FreePortFinder to DynamicPortsConfiguration.
* Remove LocalPortChecker from PortAssigner.
* Make FreePortFinder support Jackson's polymorphic deserialization
  by adding JsonTypeInfo to FreePortFinder, adding JsonTypeName
  annotation to the three FreePortFinder impls, and adding an
  io.dropwizard.jackson.Discoverable in META-INF/services, plus
  org.kiwiproject.dropwizard.util.startup.FreePortFinder also
  in META-INF/services.
* Lots of test refactoring and new tests.
* Misc: fix Javadoc in StartupLockConfiguration

Closes #545
Closes #546
Closes #547
@sleberknight sleberknight mentioned this issue Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
API change Change to a public API
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Enhance dynamic ports bundle and FreePortFinder kiwiproject/dropwizard-service-utilities
1 participant
@sleberknight