-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JUnit Pioneer and use it in ServerErrorHealthCheck #54
Comments
Added Pioneer and then attempted to use
Without changing the code in the health check, this cannot work. For example it would work if instead we only included the first few digits in the details. But in order to do that with a Do we want to do this? For example using |
Actually the above is wrong...the detail's value would be the String "0.9" rather than a number. So we'd have to convert it back to a double to be semantically correct. |
So it would need to be: .withDetail("approximateCount", Double.parseDouble(String.format("%.1f", estimatedErrorCount))) There's probably some much more sophisticated math way to do this, but... |
Decided to go ahead with this change, using the code above to set the |
* Update ServerErrorHealthCheck to show only one decimal place in the approximateCount result detail * Add JUnit Pioneer 1.1.0 with exclusions since they are only on Jupiter 5.5.2 instead of 5.7.0 * Change ServerErrorHealthCheckTest to use Pioneer's @DoubleRangeSource * Move kiwi-test dependency to its correct order below the "j" deps Closes #54 Closes #57
* Update ServerErrorHealthCheck to show only one decimal place in the approximateCount result detail * Add JUnit Pioneer 1.1.0 with exclusions since they are only on Jupiter 5.5.2 instead of 5.7.0 * Change ServerErrorHealthCheckTest to use Pioneer's @DoubleRangeSource * Move kiwi-test dependency to its correct order below the "j" deps Closes #54 Closes #57
See my original comment here: #53 (comment)
The text was updated successfully, but these errors were encountered: