Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new StandardExceptionMappers#register method that doesn't use reflection #479

Closed
sleberknight opened this issue Apr 30, 2024 · 0 comments · Fixed by #490
Closed

Add new StandardExceptionMappers#register method that doesn't use reflection #479

sleberknight opened this issue Apr 30, 2024 · 0 comments · Fixed by #490
Assignees
@sleberknight
Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Milestone
3.6.0

Comments

@sleberknight
Copy link
Member

Add register(Environment) method to StandardExceptionMappers which does not use reflection to disable the registerDefaultExceptionMappers property. It has not been necessary to do that since Dropwizard 1.0.0 even though we missed it.

Initially this method will be marked as @Beta so that it can be fully vetted in production usage.

We will leave the existing register(ServerFactory, Environment) method as-is, and not deprecate it, so that applications can choose to whether to disable Dropwizard's default exception mappers.

See #426 for background information.
@sleberknight sleberknight added the new feature A new feature such as a new class, method, package, group of classes, etc. label Apr 30, 2024
@sleberknight sleberknight added this to the 3.6.0 milestone Apr 30, 2024
@sleberknight sleberknight self-assigned this Apr 30, 2024
sleberknight added a commit that referenced this issue May 1, 2024
@sleberknight
Add new register method to StandardExceptionMappers
b2a3cbb 
* This new method does not disable the default Dropwizard ones
* Refactor the original #register method to call the new one
* Minor doc updates to existing #register method

Closes #479
@sleberknight sleberknight mentioned this issue May 1, 2024
Merged
sleberknight added a commit that referenced this issue May 1, 2024
@sleberknight
Add new register method to StandardExceptionMappers (#490)
c266314 
* This new method does not disable the default Dropwizard ones
* Refactor the original #register method to call the new one
* Minor doc updates to existing #register method

Closes #479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging a pull request may close this issue.

Add new register method to StandardExceptionMappers kiwiproject/dropwizard-service-utilities
1 participant
@sleberknight