Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add factory method to create PortAssigner.PortAssignment from a boolean #463

Closed
sleberknight opened this issue Apr 26, 2024 · 0 comments · Fixed by #466
Closed

Add factory method to create PortAssigner.PortAssignment from a boolean #463

sleberknight opened this issue Apr 26, 2024 · 0 comments · Fixed by #466
Assignees
@sleberknight
Labels
enhancement A request for change or improvement to an existing feature
Milestone
3.5.0

Comments

@sleberknight
Copy link
Member

The conversion rules are:

  • true -> PortAssignment.DYNAMIC
  • false -> PortAssignment.STATIC
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Apr 26, 2024
@sleberknight sleberknight added this to the 3.5.0 milestone Apr 26, 2024
@sleberknight sleberknight self-assigned this Apr 26, 2024
sleberknight added a commit that referenced this issue Apr 26, 2024
@sleberknight
Factory/conversion methods in PortAssigner enums
8ea3a79 
* Add factory method to create PortAssigner.PortAssignment from a boolean
* Add factory method to create PortAssigner.PortSecurity from a boolean
* Add methods to convert between PortAssigner.PortSecurity and Port.Security

Closes #463
Closes #464
Closes #465
@sleberknight sleberknight mentioned this issue Apr 26, 2024
Merged
sleberknight added a commit that referenced this issue Apr 26, 2024
@sleberknight
Factory/conversion methods in PortAssigner enums (#466)
da74f24 
* Add factory method to create PortAssigner.PortAssignment from a boolean
* Add factory method to create PortAssigner.PortSecurity from a boolean
* Add methods to convert between PortAssigner.PortSecurity and Port.Security

Closes #463
Closes #464
Closes #465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
3.5.0
Development

Successfully merging a pull request may close this issue.

Factory/conversion methods in PortAssigner enums kiwiproject/dropwizard-service-utilities
1 participant
@sleberknight