Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change return type for factory methods in ExecutionStrategies to concrete type #456

Closed
sleberknight opened this issue Apr 25, 2024 · 0 comments · Fixed by #457
Closed

Change return type for factory methods in ExecutionStrategies to concrete type #456

sleberknight opened this issue Apr 25, 2024 · 0 comments · Fixed by #457
Assignees
@sleberknight
Labels
enhancement A request for change or improvement to an existing feature
Milestone
3.5.0

Comments

@sleberknight
Copy link
Member

The rationale for this change is covered in #446 .

Even though this technically changes the public API (since the return types are changing), it won't affect existing code and is binary and source-compatible. Therefore, it does not require a major version bump.
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Apr 25, 2024
@sleberknight sleberknight added this to the 3.5.0 milestone Apr 25, 2024
@sleberknight sleberknight self-assigned this Apr 25, 2024
sleberknight added a commit that referenced this issue Apr 25, 2024
@sleberknight
Change return type for factory methods in ExecutionStrategies to conc…
3bc6885 
…rete type

Closes  #456
@sleberknight sleberknight mentioned this issue Apr 25, 2024
Merged
sleberknight added a commit that referenced this issue Apr 25, 2024
@sleberknight
Change return type for factory methods in ExecutionStrategies to conc…
178b33f 
…rete type (#457)

Closes  #456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
3.5.0
1 participant
@sleberknight