You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The class-level javadoc in PortAssigner should be amended to note that:
the ServerFactory must be provided
that ServerFactory must be an instance of DefaultServerFactory
We can also add the reason why the builder accepts a ServerFactory instead of DefaultServerFactory, which is that Dropwizard's Configuration#getServerFactory returns ServerFactory, so this allows passing that instance through to PortAssigner without a type check and cast. It is therefore a convenience, since the type check occurs during construction of PortAssigner.
The text was updated successfully, but these errors were encountered:
The class-level javadoc in
PortAssigner
should be amended to note that:ServerFactory
must be providedServerFactory
must be an instance ofDefaultServerFactory
We can also add the reason why the builder accepts a
ServerFactory
instead ofDefaultServerFactory
, which is that Dropwizard'sConfiguration#getServerFactory
returnsServerFactory
, so this allows passing that instance through toPortAssigner
without a type check and cast. It is therefore a convenience, since the type check occurs during construction ofPortAssigner
.The text was updated successfully, but these errors were encountered: