Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usages of deprecated AbstractLifeCycleListener with LifeCycle.Listener #221

Closed
sleberknight opened this issue Apr 11, 2022 · 0 comments · Fixed by #225
Closed

Replace usages of deprecated AbstractLifeCycleListener with LifeCycle.Listener #221

sleberknight opened this issue Apr 11, 2022 · 0 comments · Fixed by #225
Assignees
@sleberknight
Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Milestone
1.2.4

Comments

@sleberknight
Copy link
Member

sleberknight commented Apr 11, 2022 •
edited
Loading

In StartupJettyLifeCycleListener and StartupWithLockJettyLifeCycleListener, directly implement LifeCycle.Listener which now has default methods.

Note: This is blocked until Dropwizard is updated to 2.0.29 which depends on Jetty 9.4.46.v20220331. I'm not sure when they deprecated it, but it is definitely deprecated in that version of Jetty.
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Apr 11, 2022
@sleberknight sleberknight added this to the 1.2.4 milestone Apr 11, 2022
@sleberknight sleberknight self-assigned this Apr 11, 2022
sleberknight added a commit that referenced this issue Apr 11, 2022
@sleberknight
Replace deprecated AbstractLifeCycleListener with LifeCycle.Listener
1e57135 
* Replace deprecated AbstractLifeCycle.AbstractLifeCycleListener usages
  by implementing LifeCycle.Listener directly (it now has default
  methods so there's no need for the abstract class anymore)

Closes #221
@sleberknight sleberknight mentioned this issue Apr 11, 2022
Merged
sleberknight added a commit that referenced this issue Apr 11, 2022
@sleberknight
Replace deprecated AbstractLifeCycleListener with LifeCycle.Listener (#…
f5a0483 
…225)

* Replace deprecated AbstractLifeCycle.AbstractLifeCycleListener usages
  by implementing LifeCycle.Listener directly (it now has default
  methods so there's no need for the abstract class anymore)

Closes #221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Milestone
1.2.4
1 participant
@sleberknight