Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates due to breaking API change in kiwi 0.21.0 #115

Closed
sleberknight opened this issue Mar 24, 2021 · 0 comments · Fixed by #126
Closed

Updates due to breaking API change in kiwi 0.21.0 #115

sleberknight opened this issue Mar 24, 2021 · 0 comments · Fixed by #126
Assignees
@sleberknight
Labels
refactoring Code refactoring
Milestone
0.8.0

Comments

@sleberknight
Copy link
Member

When kiwi 0.21.0 is released, CatchingRunnable#handleExceptionSafely changes from a Throwable argument to Exception. When this occurs we need to fix/change:

  • MonitoredJob, which implements CatchingRunnable
  • JobErrorHandler interface, which should accept Exception instead of Throwable
  • Implementations of JobErrorHandler in the JobErrorHandlers utility class
@sleberknight sleberknight added the refactoring Code refactoring label Mar 24, 2021
@sleberknight sleberknight added this to the 0.8.0 milestone Mar 24, 2021
@sleberknight sleberknight self-assigned this Apr 6, 2021
sleberknight added a commit that referenced this issue Apr 6, 2021
@sleberknight
Update dependencies; updates for breaking kiwi 0.21.0 changes
c30a57e 
* Update Throwable to Exception in MonitoredJob due to breaking changes
  in kiwi 0.21.0 which changed CatchingRunnable to only handle Exception
  and not Throwable
* Change JobErrorHandler and JobErrorHandlers to only handle Exception
  for the same reason kiwi changed CatchingRunnable; Throwable should
  not be caught by application code, since it could also catch Error
  subclasses such as OutOfMemoryError, etc.

Dependency updates:
* Bump dropwizard-curator from 0.17.0 to 0.18.0
* Bump service-discovery-client from 0.14.0 to 0.15.0
* Bump registry-aware-jersey-client from 0.12.0 to 0.13.0

Closes #115
Closes #123
Closes #124
Closes #125
@sleberknight sleberknight mentioned this issue Apr 6, 2021
Merged
sleberknight added a commit that referenced this issue Apr 6, 2021
@sleberknight
Update dependencies; updates for breaking kiwi 0.21.0 changes (#126)
b329f05 
* Update Throwable to Exception in MonitoredJob due to breaking changes
  in kiwi 0.21.0 which changed CatchingRunnable to only handle Exception
  and not Throwable
* Change JobErrorHandler and JobErrorHandlers to only handle Exception
  for the same reason kiwi changed CatchingRunnable; Throwable should
  not be caught by application code, since it could also catch Error
  subclasses such as OutOfMemoryError, etc.

Dependency updates:
* Bump dropwizard-curator from 0.17.0 to 0.18.0
* Bump service-discovery-client from 0.14.0 to 0.15.0
* Bump registry-aware-jersey-client from 0.12.0 to 0.13.0

Closes #115
Closes #123
Closes #124
Closes #125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
refactoring Code refactoring
Projects
None yet
Milestone
0.8.0
1 participant
@sleberknight