New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup: InstrumentedInvokers #96

Merged

sleberknight merged 1 commit into main from code-cleanup-InstrumentedInvokers

Feb 8, 2024

Member

sleberknight commented Feb 8, 2024

Wrap requireNonNull around calls to Map#get after a containsKey check returns true
Replace explicit try/finally with try-with-resources for Timer.Context
Use var instead of "Meter meter" and "Timer timer", etc.
Remove redundant type parameter in call to rethrow


          Code cleanup: InstrumentedInvokers

6be34ec

* Wrap requireNonNull around calls to Map#get after a containsKey
  check returns true
* Replace explicit try/finally with try-with-resources for Timer.Context
* Use var instead of "Meter meter" and "Timer timer", etc.
* Remove redundant type parameter in call to rethrow

sleberknight added the code cleanup label

sleberknight added this to the 0.10.0 milestone

sleberknight self-assigned this

sonarqubecloud bot commented Feb 8, 2024

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
76.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sleberknight merged commit afaa439 into main

5 checks passed

sleberknight deleted the code-cleanup-InstrumentedInvokers branch

February 8, 2024 21:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels