Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup: more LVTI, renaming methods, removing redundant warnings #121

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Code cleanup: more LVTI, renaming methods, removing redundant warnings #121

merged 1 commit into from
Jul 5, 2024

Conversation

sleberknight
Copy link
Member

  • Rename several local vars in InstrumentedInvokerFactory#create to camelCase, e.g., timedmethods was renamed to timedMethods, for better readability.
  • Use 'var' in BasicAuthenticationInterceptorTest and JakartaXmlWsBundleTest.
  • Remove redundant "noinspection" warning suppression comments (IntelliJ let me know they are now redundant; at the time they were added, they weren't so clearly IntelliJ's analysis has improved since then).

@sleberknight
Code cleanup: more LVTI, renaming methods, removing redundant warnings
2534d9c 
* Rename several local vars in InstrumentedInvokerFactory#create
  to camelCase, e.g., timedmethods was renamed to timedMethods, for
  better readability.
* Use 'var' in BasicAuthenticationInterceptorTest and
  JakartaXmlWsBundleTest.
* Remove redundant "noinspection" warning suppression comments
  (IntelliJ let me know they are now redundant; at the time they
  were added, they weren't so clearly IntelliJ's analysis has
  improved since then).
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Jul 5, 2024
@sleberknight sleberknight added this to the 1.0.1 milestone Jul 5, 2024
@sleberknight sleberknight self-assigned this Jul 5, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sleberknight sleberknight merged commit f28328f into main Jul 5, 2024
5 checks passed
@sleberknight sleberknight deleted the more-misc-cleanup branch July 5, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sleberknight sleberknight

Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@sleberknight