Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opinionated code cleanup: use LVTI #115

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

sleberknight
Copy link
Member

@sleberknight sleberknight commented Jul 5, 2024

  • Change explicit type declarations to use 'var'
  • Rename local vars from short names like 'm' and 'sr' to more descriptive ones like 'method' and 'serverRegistry'

And no, I don't care if you ever read this and prefer code like Foo foo = new Foo()

* Change explicit type declarations to use 'var'
* Rename local vars from short names like 'm' and 'sr' to
  more descriptive ones like 'method' and 'serverRegistry'

And no, I don't care if you ever read this and prefer code
like Foo foo = new Foo(),
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Jul 5, 2024
@sleberknight sleberknight added this to the 1.0.1 milestone Jul 5, 2024
@sleberknight sleberknight self-assigned this Jul 5, 2024
Copy link

sonarqubecloud bot commented Jul 5, 2024

@sleberknight sleberknight merged commit f132225 into main Jul 5, 2024
5 checks passed
@sleberknight sleberknight deleted the prefer-LVTI-to-explicit-type branch July 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant