Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change value of BasicAuthenticationInterceptor.PRINCIPAL_KEY (breaking API change) #74

Closed
sleberknight opened this issue Nov 12, 2023 · 0 comments · Fixed by #76
Closed

Change value of BasicAuthenticationInterceptor.PRINCIPAL_KEY (breaking API change) #74

sleberknight opened this issue Nov 12, 2023 · 0 comments · Fixed by #76
Assignees
@sleberknight
Labels
API change Change to a public API
Milestone
0.7.0

Comments

@sleberknight
Copy link
Member

Change the value of BasicAuthenticationInterceptor.PRINCIPAL_KEY from "dropwizard.jaxws.principal" to "dropwizard.jakarta.xml.ws.principal" to be consistent with the package name change in #73
@sleberknight sleberknight added the API change Change to a public API label Nov 12, 2023
@sleberknight sleberknight added this to the 0.7.0 milestone Nov 12, 2023
@sleberknight sleberknight self-assigned this Nov 12, 2023
@sleberknight sleberknight changed the title Change value of BasicAuthenticationInterceptor.PRINCIPAL_KEY (breaking change) Change value of BasicAuthenticationInterceptor.PRINCIPAL_KEY (breaking API change) Nov 12, 2023
sleberknight added a commit that referenced this issue Nov 12, 2023
@sleberknight
Change value of BasicAuthenticationInterceptor.PRINCIPAL_KEY
933b936 
This is a breaking change for applications that are using this
library with basic authentication. The change needed in those
applications is to change the key requested from the message
context to the new value of PRINCIPAL_KEY, which is now
"dropwizard.jakarta.xml.ws.principal"

Also, added the current date/time in the output of
JavaFirstServiceImpl and the two HTTP resource classes, so that
it is clear that new requests are being made, e.g. in a browser

Closes #74
@sleberknight sleberknight mentioned this issue Nov 12, 2023
Merged
sleberknight added a commit that referenced this issue Nov 12, 2023
@sleberknight
Change value of BasicAuthenticationInterceptor.PRINCIPAL_KEY (#76)
fee8cd9 
This is a breaking change for applications that are using this library
with basic authentication. The change needed in those applications is to
change the key requested from the message context to the new value of
PRINCIPAL_KEY, which is now "dropwizard.jakarta.xml.ws.principal"

Also, added the current date/time in the output of JavaFirstServiceImpl
and the two HTTP resource classes, so that it is clear that new requests
are being made, e.g. in a browser

Closes #74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
API change Change to a public API
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Change value of BasicAuthenticationInterceptor.PRINCIPAL_KEY kiwiproject/dropwizard-jakarta-xml-ws
1 participant
@sleberknight