Skip to content

Commit

Permalink
Use kiwi-parent as the overall parent POM (#25)
Browse files Browse the repository at this point in the history 
* Add kiwi-parent as the parent POM of the root POM
* Remove all the things that kiwi-parent already defines
  • Loading branch information
@sleberknight
sleberknight authored Nov 6, 2023
1 parent f375156 commit 51d9654
Showing 1 changed file with 41 additions and 166 deletions.
207 changes: 41 additions & 166 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.kiwiproject</groupId>
<artifactId>kiwi-parent</artifactId>
<version>3.0.4</version>
</parent>

<groupId>com.github.roskart.dropwizard-jaxws</groupId>
<artifactId>dropwizard-jaxws-parent</artifactId>
<version>1.2.3</version>
Expand All @@ -21,27 +27,25 @@
</modules>

<properties>
<java.version>17</java.version>

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

<dropwizard.version>4.0.3</dropwizard.version>
<cxf.version>4.0.3</cxf.version>
<jakarta.mail-api.version>2.1.2</jakarta.mail-api.version>

<assertj.version>3.24.2</assertj.version>
<junit.version>5.10.1</junit.version>
<mockito.version>5.7.0</mockito.version>

<maven-compiler-plugin.version>3.11.0</maven-compiler-plugin.version>
<maven-enforcer-plugin.version>3.4.1</maven-enforcer-plugin.version>
<maven-gpg-plugin.version>3.1.0</maven-gpg-plugin.version>
<maven-jar-plugin.version>3.3.0</maven-jar-plugin.version>
<maven-javadoc-plugin.version>3.6.0</maven-javadoc-plugin.version>
<maven-source-plugin.version>3.3.0</maven-source-plugin.version>
<versions-maven-plugin.version>2.16.1</versions-maven-plugin.version>

<!--
NOTE:
We are using Jakarta Persistence and Transaction APIs from Jakarta EE 10 here, but using
the JAXB runtime version compatible with Jakarta EE 9. I think this will work because
Dropwizard 4.x is using Hibernate 6.1.x which says (see https://hibernate.org/orm/releases/6.1/)
it is compatible with both Jakarta Persistence 3.1 (Jakarta EE 10) and 3.0 (Jakarta EE 9).
The kiwi-bom uses Hibernate 6.3.x which is compatible with Jakarta Persistence 3.1 (Jakarta EE 10)
and it seems to work fine with Dropwizard 4.x. Plus, Hibernate 6.1.x is EOL (end-of-life) so we
don't really want to be using it. But, we are also mandating the JAXB runtime version that is
Jakarta EE 9 compatible, since that is what Dropwizard 4.x is compatible with.
-->
<jakarta.persistence-api.version>3.1.0</jakarta.persistence-api.version>
<jakarta.transaction-api.version>2.0.1</jakarta.transaction-api.version>
<jaxb-runtime.version>3.0.2</jaxb-runtime.version>
<kiwi-bom.version>2.0.3</kiwi-bom.version>
</properties>

<developers>
Expand Down Expand Up @@ -83,83 +87,32 @@
</repository>
</distributionManagement>

<profiles>

<profile>
<id>release</id>
<build>
<plugins>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<version>${maven-gpg-plugin.version}</version>
<executions>
<execution>
<id>sign-artifacts</id>
<phase>verify</phase>
<goals>
<goal>sign</goal>
</goals>
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>${maven-source-plugin.version}</version>
<executions>
<execution>
<id>attach-sources</id>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>${maven-javadoc-plugin.version}</version>
<configuration>
<quiet>true</quiet>
<additionalparam>-Xdoclint:none</additionalparam>
</configuration>
<executions>
<execution>
<id>attach-javadocs</id>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
</plugin>

</plugins>
</build>
</profile>

</profiles>

<dependencyManagement>
<dependencies>

<dependency>
<groupId>io.dropwizard</groupId>
<artifactId>dropwizard-bom</artifactId>
<version>${dropwizard.version}</version>
<scope>import</scope>
<groupId>org.kiwiproject</groupId>
<artifactId>kiwi-bom</artifactId>
<version>${kiwi-bom.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>

<dependency>
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>${junit.version}</version>
<type>pom</type>
<scope>import</scope>
<groupId>jakarta.persistence</groupId>
<artifactId>jakarta.persistence-api</artifactId>
<version>${jakarta.persistence-api.version}</version>
</dependency>

<dependency>
<groupId>jakarta.transaction</groupId>
<artifactId>jakarta.transaction-api</artifactId>
<version>${jakarta.transaction-api.version}</version>
</dependency>

<dependency>
<groupId>org.glassfish.jaxb</groupId>
<artifactId>jaxb-runtime</artifactId>
<version>${jaxb-runtime.version}</version>
</dependency>

<dependency>
Expand All @@ -172,85 +125,7 @@
</dependencyManagement>

<dependencies>

<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
<version>${assertj.version}</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>${mockito.version}</version>
<scope>test</scope>
</dependency>

<!-- nothing to see here...move along...move along... -->
</dependencies>

<build>

<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>${maven-compiler-plugin.version}</version>
<configuration>
<release>${java.version}</release>
<encoding>UTF-8</encoding>
</configuration>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>${maven-jar-plugin.version}</version>
<configuration>
<archive>
<manifest>
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest>
</archive>
</configuration>
</plugin>

<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>versions-maven-plugin</artifactId>
<version>${versions-maven-plugin.version}</version>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<version>${maven-enforcer-plugin.version}</version>
<executions>
<execution>
<id>enforce</id>
<configuration>
<rules>
<!-- <dependencyConvergence /> -->
<requireMavenVersion>
<version>3.3.9</version>
</requireMavenVersion>
</rules>
</configuration>
<goals>
<goal>enforce</goal>
</goals>
</execution>
</executions>
</plugin>

</plugins>

</build>

</project>

0 comments on commit 51d9654

Please sign in to comment.